Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.html #3315

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update index.html #3315

wants to merge 1 commit into from

Conversation

Yashika0108
Copy link

@Yashika0108 Yashika0108 commented Oct 15, 2024

This works better .
The <div> with class container-lg is not closed properly, it should be closed after the loop that generates article cards.

  • The images are loaded from a specific path (/assets/images/illos/). Make sure this path is correct in your project structure.

Error- Also the word YouTube doesn't changes its language as others changes

  • Have you followed the contributing guidelines?
  • Have you explained what your changes do, and why they add value to the Guides?

Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.


This works better .
The `<div>` with class `container-lg` is not closed properly, it should be closed after the loop that generates article cards.
- The images are loaded from a specific path (`/assets/images/illos/`). Make sure this path is correct in your project structure.

Error- Also the word YouTube doesn't changes its language as others changes
@Yashika0108 Yashika0108 requested a review from a team as a code owner October 15, 2024 21:30
@Yashika0108
Copy link
Author

This works better .
The <div> with class container-lg is not closed properly, it should be closed after the loop that generates article cards.

  • The images are loaded from a specific path (/assets/images/illos/). Make sure this path is correct in your project structure.

Error- Also the word YouTube doesn't changes its language as others changes

@jmeridth
Copy link
Member

You can't remove the liquid templating. Please place that back and then we can look at the other changes. Look at your deployment to confirm. Also the word Youtube is not in the index.html. The repeated description on this PR makes me think bot. Please prove otherwise. Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants