Python: Add support for type parameter defaults #17688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tausbn
force-pushed
the
tausbn/python-3.13-default-type-parser-support
branch
from
cdd7e2d
to
f2d2411
Compare
tausbn
force-pushed
the
tausbn/python-3.13-default-type-parser-support
branch
from
58a4698
to
8d41922
Compare
tausbn
added
the
Awaiting evaluation
tausbn
force-pushed
the
tausbn/python-3.13-default-type-parser-support
branch
2 times, most recently
from
fe15ce6
to
ba03d92
Compare
Also fixes an oversight in the grammar: starred expressions should be allowed inside the subscript of an `Index` expression.
Two new files -- alloc.h and array.h -- suddenly appeared. Presumably they are used by the somewhat newer version of tree-sitter. To be safe, I included them in this commit.
There was an errant `ql` in the relevant paths, a leftover from the move from the internal repo. Also, we can no longer rely on an intree version of the CodeQL CLI, so from now on we'll just assume it's present in the path. (On Codespaces, `gh codeql` is a decent replacement, especially if using the `install-stub` functionality.
Note that this still includes the somewhat puzzling parsing of `Spam[**P2]` as an exponentiation with an empty left hand side. When we fix that bug, we should also update this test to contain actually valid syntax.
Adds up- and downgrade scripts for the support for type parameter defaults. In the upgrade direction we do nothing, matching the behaviour of `getDefault` not having a result for old databases. In the downgrade direction, we explicitly remove the relevant child (via the `py_exprs` database relation) for `TypeVar`, `TypeVarTuple`, and `ParamSpec` parameters.
tausbn
force-pushed
the
tausbn/python-3.13-default-type-parser-support
branch
from
ba03d92
to
417e60a
Compare
|
Had to fix up the commit message for the upgrade scripts (as it was now misleading) and rebase so that I could update the extractor version, hence the need to re-review. Apart from that, there are no changes compared to what was reviewed previously. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the new syntax for default values for type parameters, as documented in PEP-696.
Pull Request checklist
All query authors
.qhelp. See the documentation in this repository.Internal query authors only
.ql,.qll, or.qhelpfiles. See the documentation (internal access required).