Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patches from Debian package #370

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

keith-packard
Copy link

@keith-packard keith-packard commented Jan 6, 2025

Here's a set of patches that I wrote as a part of packaging cmark-gfm for Debian.

  1. Install more headers for library users. I'm unsure whether these are still required, but as of gfm.6 they were.
  2. Add missing command line options to the man page.
  3. Add an environment variable, CMARK_TIMING_SCALE, to increase test timeouts. Some debian targets are so slow that even the generous timeouts aren't long enough. I use CMARK_TIMING_SCALE=10 for debian packaging to ensure that even hppa builds work.
  4. Fix python regex syntax errors in tests. Back slashes must be escaped (with another backslash) in regex strings.
  5. test/pathological_tests.py was using allowed_failures incorrectly.

These are needed to actually use the library it seems.

Signed-off-by: Keith Packard <[email protected]>
These options were documented in --help but missing from the man page.

Signed-off-by: Keith Packard <[email protected]>
Some hardware is really slow; let users set CMARK_TIMING_SCALE to
multiply the timeouts by an arbitrary amount

Signed-off-by: Keith Packard <[email protected]>
The regular expressions in normalize.py and pathological_tests.py are
missing a lot of backslashes -- you need two in the source file to get
one in the string.

Signed-off-by: Keith Packard <[email protected]>
The test needs to check if the test description is a valid key in the
allowed_failures dictionary instead of attempting to fetch from the
dictionary as most of the descriptions are not present in the
dictionary leading to a missing key error at runtime.

Signed-off-by: Keith Packard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant