-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHSA-93ww-43rr-79v3] Keycloak mTLS Authentication Bypass via Reverse Proxy TLS Termination #5236
[GHSA-93ww-43rr-79v3] Keycloak mTLS Authentication Bypass via Reverse Proxy TLS Termination #5236
Conversation
Hi there @jonkoops! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
The last release in Keycloak 24.x was 24.0.5, after that there have (and will not) be any further official releases. The fix linked here is in a branch that is used for LTS variants for various downstreams (e.g.Red Hat build of Keycloak). |
Thanks for the context @jonkoops and good to know. @westonsteimel, given that the patched version isn't (and won't) be published to maven central I'm not sure we want to add it to our advisory. I think the fix commit would be good to have, but thoughts? |
Should we add 26.0.6 as the recommended patch for the 24.x range then as well? |
Oh that's a thought. I suppose we would be suggesting a potentially breaking change, but it wouldn't be the first time. Any opposition @jonkoops or are you ok with suggesting 24.x users migrate to 26? |
I am not sure why it ended up in the advisory, but I believe |
So just drop the |
@jonkoops Yes, I think that 24.0.9 can be deleted in that advisory. But just upgrade to 26.0.6 or later. |
Great, if you would like to make the changes @westonsteimel that would be appreciated. |
Hi there @jonkoops! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the changes requested by @jonkoops
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6eafa56
into
westonsteimel/advisory-improvement-5236
Hi @westonsteimel! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Merged in. Thanks all 👍 |
Updates
Comments
just adding 24.0.9 to the patch list, the affected range was already < 24.0.9
keycloak/keycloak@3da16ee