Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBASIC heuristic #7186

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

DecimalTurn
Copy link
Contributor

Description

This PR removes one of the rules from the FreeBASIC heuristics. While this rule was valid to distinguish FreeBASIC and Classic QuickBASIC, it classified a lot of QB64 code file as FreeBASIC, since the dim as name1 DataType syntax was also added to QB64.

Related: #7080

Checklist:

@DecimalTurn DecimalTurn requested a review from a team as a code owner January 1, 2025 19:14
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Important

The changes in this PR will not appear on GitHub until the next release has been made and deployed. See here for more details.

@lildude lildude added this pull request to the merge queue Jan 8, 2025
Merged via the queue into github-linguist:main with commit f15ab0b Jan 8, 2025
5 checks passed
@DecimalTurn DecimalTurn deleted the fb-vs-qb branch January 15, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants