-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Power Query (.pq) language support #4191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like .pqm
is still not popular enough so can’t be included in this PR. .pq
might just be (I’ll check later) however you’re going to need to add a heuristic as this extension is not unique to PowerQuery as demonstrated by your complex search.
👍
It could be sufficient to add @mattmasson Also, any idea what these files are? |
Looks like Total files found: 648 |
Yes, Makefile.pq seems to be common name for a specific kind of makefile. There also seems to be some .pq files that are gnuplot oriented. Here is a better search that pulls in both .pqm and .pq files. Power Query code will always contain either "section" or "let" statements. @lildude, what is the minimum counts we should have before resubmitting? @pchaigno, what else can I change in linguist to make sure the Makefile.pq and gnuplot files aren't misclassified? |
We don't have a specific count beyond "In most cases we prefer that extensions be in use in hundreds of repositories before supporting them in Linguist." as stated in the CONTRIBUTING.md. Technically speaking, "hundreds" would signal at least 200, else it'll only be "hundred" 😉, though that's probably still on the low side as it's barely into the "hundreds" range. It also depends on how well spread out across users this is; 1000 unique repos for 2 users is not widespread usage. The biggest limitation to us specifying precise figures is there's no easy way for peeps to quantify usage as this isn't exposed within the search results and querying the API to gain this info hits rate and abuse limits. I'm hoping that when code search comes to GraphQL, we can write an app or script to query the results without hitting rate limiting thus getting us out of this situation. |
The |
Hello Guys |
any plans to add language references for |
There are never any plans to add a language as contributions are entirely community driven. Submit a PR and we're likely to add support for that language or extensions provided the extensions meet the minimum usage requirements. |
thanks @lildude - I will have to decide if its worth the time and effort or not then I guess! |
Adds Power Query language support (.pq and .pqm)
Description
The Power Query / M formula language is a DSL for the Power Query Editor experience in Microsoft's Power BI, Excel, and SQL Server Analysis Services, and other products. This change adds highlighting support for .pq and .pqm files.
The PQ language was previously submitted in August 2017 (#3802) and not accepted (Pending Popularity). At the time the search results came back with ~75 URLs; we now have over 700.
Checklist: