Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build usb image by default #196

Closed
wants to merge 2 commits into from
Closed

build usb image by default #196

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecea9f4
build usb image by default
mrbojangles3 Oct 22, 2024
6120df6
don't change the flag
mrbojangles3 Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/hhfab/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ func Run(ctx context.Context) error {
Aliases: []string{"usb"},
Usage: "use installer USB image for control node(s)",
EnvVars: []string{"HHFAB_CONTROL_USB"},
Value: false,
Value: true,
},
),
Before: before(false),
Expand Down Expand Up @@ -550,7 +550,7 @@ func Run(ctx context.Context) error {
Aliases: []string{"usb"},
Usage: "use installer USB image for control node(s)",
EnvVars: []string{"HHFAB_CONTROL_USB"},
Value: false,
Value: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really make sense for VLAB as it'll be very non-transparent for the user - just waiting for the control node to be up or not

},
&cli.BoolFlag{
Name: FlagNameFailFast,
Expand Down
Loading