Replace Bun with pnpm #306

sakit0 · 2025-01-13T07:59:48Z

Summary

This pull request replaces Bun with pnpm across the project, updates scripts and CI workflows accordingly, and switches test imports to use Vitest.

Related Issue

#215

Changes

Refactor package.json to replace Bun with pnpm for script commands and update package manager version
Replace Bun with pnpm in CI workflows and related scripts
Update CONTRIBUTING.md to replace Bun with pnpm in setup instructions
Replace Bun with pnpm and update test imports to use Vitest
Added several missing packages that caused type errors and made the build fail.
Encountered a type error with Timer, so changed it to NodeJS.Timeout .

Testing

Verified that all scripts now run successfully with pnpm
Confirmed CI pipelines pass without Bun
Ran tests locally with Vitest to ensure no breaking changes

Other Information

Additional documentation may be needed if there are references to Bun elsewhere.

…d update package manager version

vercel · 2025-01-13T07:59:52Z

@sakit0 is attempting to deploy a commit to the Edge Team on Vercel.

A member of the Team first needs to authorize it.

vercel · 2025-01-13T08:00:09Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
giselle	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 27, 2025 5:44am

…@10.0.0

….yaml

…o-pnpm

…package.json

…to package.json and pnpm-lock.yaml

…-lock.yaml

shige · 2025-01-20T07:54:47Z

package.json

@@ -27,11 +28,14 @@
 		"@octokit/request-error": "6.1.5",
 		"@octokit/webhooks": "13.3.0",
 		"@opentelemetry/api": "1.9.0",
+		"@opentelemetry/api-logs": "^0.57.1",


@sakit0 We have stopped using ^ in this issue #293, so please make the necessary adjustments accordingly!

fix!!
81b86f9

…stency

shige · 2025-01-20T08:09:45Z

@sakit0 Could you please fix the following GitHub Actions error?

pnpm-lock.yaml » [email protected] – cookie accepts cookie name, path, and domain with out of bounds characters (low severity)

https://github.com/giselles-ai/giselle/actions/runs/12863427739/job/35859984948?pr=306#step:3:6

I will fix the GitHub Actions license_finder!

shige · 2025-01-20T11:59:31Z

@sakit0 Could you please update like this commit 7b99788 to resolve the GitHub Actions error?

….yml

sakit0 · 2025-01-20T15:36:13Z

@shige
fixed!
https://github.com/giselles-ai/giselle/pull/306/files#diff-e8382de87f09cf3097ced97ff39a879690384c00cc63cc91b6d5bd14cee973fc

… consistency

…sistency

sakit0 · 2025-01-24T04:53:34Z

@shige
Can I merge this PR?

shige · 2025-01-24T04:58:37Z

@sakit0 Could you please check the following comments? The CI is failing, so I would like you to fix it.

Could you please fix the following GitHub Actions error?

pnpm-lock.yaml » [email protected] – cookie accepts cookie name, path, and domain with out of bounds characters (low severity)

https://github.com/giselles-ai/giselle/actions/runs/12863427739/job/35859984948?pr=306#step:3:6

…o-pnpm

sakit0 · 2025-01-27T05:42:01Z

@shige
I overlooked it!
I will override it until it is addressed in the following release: supabase/ssr#80

95f2964

shige

@sakit0 LGTM 🎉

sakit0 added 4 commits January 13, 2025 15:08

Refactor package.json to replace bun with pnpm for script commands an…

004ad9b

…d update package manager version

Replace bun with pnpm in CI workflows and related scripts

81cc8f4

Update CONTRIBUTING.md to replace bun with pnpm in setup instructions

61c40fe

Replace bun with pnpm and update test imports to use vitest

4bf10c3

vercel bot had a problem deploying to Preview January 13, 2025 08:01 Failure

sakit0 changed the title ~~Chore/migrate bun to pnpm~~ Replace Bun with pnpm Jan 13, 2025

Remove "type" field from package.json and set package manager to pnpm…

e97b398

…@10.0.0

vercel bot had a problem deploying to Preview January 13, 2025 08:23 Failure

sakit0 added 2 commits January 13, 2025 17:56

Add @supabase/auth-js dependency to package.json and update pnpm-lock…

ceb7c4b

….yaml

Refactor package.json to format trustedDependencies array

3f8695c

vercel bot had a problem deploying to Preview January 13, 2025 10:03 Failure

sakit0 added 3 commits January 20, 2025 14:56

Merge remote-tracking branch 'upstream/main' into chore/migrate-bun-t…

838e31c

…o-pnpm

update pnpm-lock.yaml

721a65f

Add pnpm workspace configuration file

c34fd84

vercel bot had a problem deploying to Preview January 20, 2025 06:14 Failure

sakit0 added 2 commits January 20, 2025 15:15

update pnpm-lock.yaml

fd71a60

Update biome.json to ignore additional package directory

9c54833

vercel bot had a problem deploying to Preview January 20, 2025 06:24 Failure

Add overrides for @supabase/auth-js to package.json

0fa0398

vercel bot had a problem deploying to Preview January 20, 2025 06:35 Failure

Update @supabase/auth-js version to 2.64.4 and remove overrides from …

9115cbf

…package.json

vercel bot had a problem deploying to Preview January 20, 2025 06:45 Failure

Refactor timeout references to use NodeJS.Timeout type

f89842b

vercel bot had a problem deploying to Preview January 20, 2025 06:56 Failure

sakit0 added 2 commits January 20, 2025 15:59

Add @opentelemetry/api-logs and @opentelemetry/sdk-logs dependencies …

603bf19

…to package.json and pnpm-lock.yaml

fix format

17ed60e

vercel bot had a problem deploying to Preview January 20, 2025 07:11 Failure

Add @opentelemetry/sdk-trace-base dependency to package.json and pnpm…

ca8d013

…-lock.yaml

vercel bot deployed to Preview January 20, 2025 07:38 View deployment

sakit0 marked this pull request as ready for review January 20, 2025 07:41

sakit0 requested review from shige and toyamarinyon as code owners January 20, 2025 07:41

shige reviewed Jan 20, 2025

View reviewed changes

fix(package): update version specifiers to remove caret (^) for consi…

81b86f9

…stency

toyamarinyon approved these changes Jan 20, 2025

View reviewed changes

vercel bot deployed to Preview January 20, 2025 08:03 View deployment

shige mentioned this pull request Jan 20, 2025

[DNM] Permitted 'MIT-0' license #317

Closed

Add new dependency decision for MIT-0 license in dependency_decisions…

2675db8

….yml

vercel bot deployed to Preview January 20, 2025 15:39 View deployment

sakit0 added 2 commits January 21, 2025 00:43

fix(dependency_decisions): update MIT-0 license entry for clarity and…

7641944

… consistency

fix(dependency_decisions): remove quotes around MIT-0 license for con…

7f12b1c

…sistency

vercel bot deployed to Preview January 20, 2025 15:51 View deployment

sakit0 added 2 commits January 27, 2025 14:24

Merge remote-tracking branch 'upstream/main' into chore/migrate-bun-t…

9e1ecb0

…o-pnpm

Add cookie override to package.json

95f2964

vercel bot deployed to Preview January 27, 2025 05:44 View deployment

shige assigned sakit0 Jan 27, 2025

shige self-requested a review January 27, 2025 06:06

shige approved these changes Jan 27, 2025

View reviewed changes

shige merged commit 3cb8d9f into giselles-ai:main Jan 27, 2025
4 of 5 checks passed

shige mentioned this pull request Jan 27, 2025

Revert the changes made in "Add cookie override to package.json" #334

Open

3 tasks

sakit0 deleted the chore/migrate-bun-to-pnpm branch January 27, 2025 06:39

shige mentioned this pull request Jan 27, 2025

Notify workflow failure with Email when the workflow is triggered by webhooks #333

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace Bun with pnpm #306

Replace Bun with pnpm #306

sakit0 commented Jan 13, 2025 •

edited

Loading

vercel bot commented Jan 13, 2025

vercel bot commented Jan 13, 2025 •

edited

Loading

shige Jan 20, 2025

sakit0 Jan 20, 2025

shige commented Jan 20, 2025

shige commented Jan 20, 2025

sakit0 commented Jan 20, 2025 •

edited

Loading

sakit0 commented Jan 24, 2025

shige commented Jan 24, 2025

sakit0 commented Jan 27, 2025

shige left a comment

Replace Bun with pnpm #306

Replace Bun with pnpm #306

Conversation

sakit0 commented Jan 13, 2025 • edited Loading

Summary

Related Issue

Changes

Testing

Other Information

vercel bot commented Jan 13, 2025

vercel bot commented Jan 13, 2025 • edited Loading

shige Jan 20, 2025

Choose a reason for hiding this comment

sakit0 Jan 20, 2025

Choose a reason for hiding this comment

shige commented Jan 20, 2025

shige commented Jan 20, 2025

sakit0 commented Jan 20, 2025 • edited Loading

sakit0 commented Jan 24, 2025

shige commented Jan 24, 2025

sakit0 commented Jan 27, 2025

shige left a comment

Choose a reason for hiding this comment

sakit0 commented Jan 13, 2025 •

edited

Loading

vercel bot commented Jan 13, 2025 •

edited

Loading

sakit0 commented Jan 20, 2025 •

edited

Loading