Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build plugin client code on release #1777

Open
wants to merge 5 commits into
base: girder-5
Choose a base branch
from
Open

Build plugin client code on release #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcb2c4c
Build large_image and annotation plugins on release
naglepuff Jan 17, 2025
5cb51e4
Use tox-and-node image for release check job
naglepuff Jan 17, 2025
9c9386d
Check node versions in check_release
naglepuff Jan 17, 2025
5462e87
Use correct node version
naglepuff Jan 17, 2025
eae3afd
Use nvm in check_release environment
naglepuff Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,11 @@ jobs:
path: ~/wheels
check_release:
docker:
- image: cimg/python:3.10
- image: girder/tox-and-node
parameters:
node:
type: string
default: v20
steps:
- checkout
- run:
Expand All @@ -307,6 +311,27 @@ jobs:
- run:
name: Install python packages
command: pip install setuptools_scm twine
- run:
name: Use nvm
# see https://discuss.circleci.com/t/nvm-does-not-change-node-version-on-machine/28973/14
command: |
echo 'export NVM_DIR="/opt/circleci/.nvm"' >> $BASH_ENV
echo '[ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"' >> $BASH_ENV
- restore_cache:
name: Restore nvm cache
key: v1-nvm-cache-<< parameters.node >>
- run:
name: Switch node versions
command: |
nvm install << parameters.node >>
nvm alias default << parameters.node >>
NODE_DIR=$(dirname $(which node))
echo "export PATH=$NODE_DIR:\$PATH" >> $BASH_ENV
- run:
name: Check node versions
command: |
node --version
npm --version
- run:
name: Check release to PyPi
command: ./.circleci/release_pypi.sh check
Expand Down
11 changes: 11 additions & 0 deletions .circleci/release_pypi.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,22 @@ twine ${1:-check} $( [[ "${1:-check}" == "upload" ]] && printf %s '--verbose' )
cd "$ROOTPATH/girder"
cp "$ROOTPATH/README.rst" .
cp "$ROOTPATH/LICENSE" .
# Build the client plugin code
pushd "$ROOTPATH/girder/girder_large_image/web_client/"
npm ci
npm run build
popd
python setup.py sdist
pip wheel . --no-deps -w dist
twine ${1:-check} $( [[ "${1:-check}" == "upload" ]] && printf %s '--verbose' ) dist/*
cd "$ROOTPATH/girder_annotation"
cp "$ROOTPATH/README.rst" .
cp "$ROOTPATH/LICENSE" .
# Build the client plugin code
pushd "$ROOTPATH/girder_annotation/girder_large_image_annotation/web_client/"
npm ci
npm run build
popd
python setup.py sdist
pip wheel . --no-deps -w dist
twine ${1:-check} $( [[ "${1:-check}" == "upload" ]] && printf %s '--verbose' ) dist/*
Expand Down Expand Up @@ -49,6 +59,7 @@ twine ${1:-check} $( [[ "${1:-check}" == "upload" ]] && printf %s '--verbose' )
cd "$ROOTPATH/sources/dicom"
cp "$ROOTPATH/README.rst" .
cp "$ROOTPATH/LICENSE" .
# TODO build DICOMweb plugin client code when converted
python setup.py sdist
pip wheel . --no-deps -w dist
twine ${1:-check} $( [[ "${1:-check}" == "upload" ]] && printf %s '--verbose' ) dist/*
Expand Down
Loading