Merge pull request #1359 from psavery/limit-default-none

Default to "None" for the limit
girder · Nov 3, 2023 · 295a894 · 295a894
2 parents 7657a98 + 2a2d355
commit 295a894
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/sources/dicom/large_image_source_dicom/assetstore/rest.py b/sources/dicom/large_image_source_dicom/assetstore/rest.py
@@ -79,7 +79,7 @@ def _importData(self, assetstore, params, progress):
                enum=('folder', 'user', 'collection'),
                required=True)
         .param('limit', 'The maximum number of results to import.',
-               required=False, dataType='int')
+               required=False, default=None)
         .param('filters', 'Any search parameters to filter DICOM objects.',
                required=False, default='{}')
         .param('progress', 'Whether to record progress on this operation.',

diff --git a/sources/dicom/test_dicom/web_client_specs/dicomWebSpec.js b/sources/dicom/test_dicom/web_client_specs/dicomWebSpec.js
@@ -112,7 +112,7 @@ describe('DICOMWeb assetstore', function () {
         });
 
         waitsFor(function () {
-            return $('.g-validation-failed-message').html().includes('Invalid value');
+            return $('.g-validation-failed-message').html() === 'Invalid limit';
         }, 'Invalid limit check (float)');
 
         runs(function () {