feat(GiniHealthSDK): Brand ingredient configuration #766

razvancapra · 2025-01-15T13:11:42Z

IPC-507

…selection and review screen based on configuration IPC-507

…small fixes

… added in GiniInternalPaymentSDK

zladzeyka

Thank you @razvancapra
Please find some notes below:

...lPaymentSDK/Sources/GiniInternalPaymentSDK/PaymentComponents/PaymentComponentViewModel.swift

zladzeyka · 2025-01-20T11:07:39Z

GiniComponents/GiniUtilites/Sources/GiniUtilites/GiniLocalization.swift

@@ -16,6 +16,17 @@ public enum GiniLocalization: String, CaseIterable {
    case de = "de"
 }

+/**
+ An enumeration representing the visibility type of an ingredient brand.
+


Suggested change

zladzeyka · 2025-01-20T11:17:07Z

...ibrary/Sources/GiniHealthAPILibrary/Documents/Configuration/ClientConfigurationService.swift

+ This service implements the `ClientConfigurationServiceProtocol` and provides methods to retrieve configuration data from a specified API domain.
+ */
+public final class ClientConfigurationService: ClientConfigurationServiceProtocol {
+    /**


Suggestion:
Please follow the comment style that you use in the past

`/**
Initializes a new instance of GiniMerchant.

This initializer creates a GiniMerchant instance by first constructing a Client object with the provided client credentials (id, secret, domain) - Parameters: - id: The client ID provided by Gini when you register your application. This is a unique identifier for your application. - secret: The client secret provided by Gini alongside the client ID. This is used to authenticate your application to the Gini API. - domain: The domain associated with your client credentials. This is used to scope the client credentials to a specific domain. - pinningConfig: Configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]] - logLevel: The log level. `LogLevel.none` by default. */`

zladzeyka · 2025-01-20T11:19:09Z

...HealthAPILibrary/Documents/Configuration/ClientConfigurationServiceProtocol+Extensions.swift

+import Foundation
+
+extension ClientConfigurationServiceProtocol {
+    /**


[Suggestion]: Please use the comment format

/** Initializes a new instance of GiniMerchant. This initializer creates a GiniMerchant instance by first constructing a Client object with the provided client credentials (id, secret, domain) - Parameters: - id: The client ID provided by Gini when you register your application. This is a unique identifier for your application. - secret: The client secret provided by Gini alongside the client ID. This is used to authenticate your application to the Gini API. - domain: The domain associated with your client credentials. This is used to scope the client credentials to a specific domain. - pinningConfig: Configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]] - logLevel: The log level. `LogLevel.none` by default. */

zladzeyka · 2025-01-20T11:21:08Z

...ources/GiniHealthAPILibrary/Documents/Configuration/ClientConfigurationServiceProtocol.swift

+ Protocol for client configuration service
+ */
+public protocol ClientConfigurationServiceProtocol: AnyObject {
+    /**


[Suggestion]: Please use the comment format :

/** Initializes a new instance of GiniMerchant. This initializer creates a GiniMerchant instance by first constructing a Client object with the provided client credentials (id, secret, domain) - Parameters: - id: The client ID provided by Gini when you register your application. This is a unique identifier for your application. - secret: The client secret provided by Gini alongside the client ID. This is used to authenticate your application to the Gini API. - domain: The domain associated with your client credentials. This is used to scope the client credentials to a specific domain. - pinningConfig: Configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]] - logLevel: The log level. `LogLevel.none` by default. */

zladzeyka · 2025-01-20T11:21:57Z

...y/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/Core/ClientConfiguration.swift

+ */
+public struct ClientConfiguration: Codable {
+    /**
+     Creates a new `ClientConfiguration` instance.


[Suggestion]: Please use the comment format :

/** Initializes a new instance of GiniMerchant. This initializer creates a GiniMerchant instance by first constructing a Client object with the provided client credentials (id, secret, domain) - Parameters: - id: The client ID provided by Gini when you register your application. This is a unique identifier for your application. - secret: The client secret provided by Gini alongside the client ID. This is used to authenticate your application to the Gini API. - domain: The domain associated with your client credentials. This is used to scope the client credentials to a specific domain. - pinningConfig: Configuration for certificate pinning. Format ["PinnedDomains" : ["PublicKeyHashes"]] - logLevel: The log level. `LogLevel.none` by default. */

zladzeyka · 2025-01-20T11:23:31Z

...y/GiniHealthAPILibrary/Sources/GiniHealthAPILibrary/Documents/Core/ClientConfiguration.swift

+     - parameter comunicationTone: A configuration that indicates the comunication tone of the texts. Defaults to `nil
+     - parameter ingredientBrandType: A configuration that indicates the presence of the ingredient brand. Defaults to `nil`.
+     */
+    public init(clientID: String,


[Clarification]: one of our customers is using AlternativeTokenSource and there is no clientID, how will we handle that?

That's a good question. We need to ask backend team.

zladzeyka · 2025-01-20T11:28:47Z

HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponentsController.swift

@@ -126,6 +127,7 @@ public final class PaymentComponentsController: BottomSheetsProviderProtocol, Gi
        self.stringsProvider = giniHealth
        setupObservers()
        loadPaymentProviders()
+        fetchAndConfigureClientConfiguration()


Suggested change

fetchAndConfigureClientConfiguration()

fetchAndUpdateClientConfiguration()

zladzeyka · 2025-01-20T11:31:21Z

HealthSDK/GiniHealthSDK/Tests/GiniHealthSDKTests/PaymentComponentsControllerTests.swift

@@ -169,7 +170,8 @@ final class PaymentComponentsControllerTests: XCTestCase {
                                                   poweredByGiniStrings: giniHealth.poweredByGiniStrings,
                                                   moreInformationConfiguration: giniHealth.moreInformationConfiguration,
                                                   moreInformationStrings: giniHealth.moreInformationStrings,
-                                                   urlOpener: URLOpener(MockUIApplication(canOpen: false)))
+                                                   urlOpener: URLOpener(MockUIApplication(canOpen: false)),
+                                                   clientConfiguration: nil)


[Clarification]: why do we always pass clientConfiguration: nil in tests?

We don't have any tests for client configuration. Should we create some?

IPC-507

sonarqubecloud · 2025-01-30T09:22:27Z

Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.1% Duplication on New Code

See analysis details on SonarQube Cloud

zladzeyka

@razvancapra please check a tiny suggestion: you removed accidentally whitespace and it's good to go in QA

zladzeyka · 2025-02-06T13:17:21Z

HealthSDK/GiniHealthSDK/Sources/GiniHealthSDK/Core/GiniHealthConfiguration.swift

@@ -153,7 +154,12 @@ public final class GiniHealthConfiguration: NSObject {
    /**
    Custom localization configuration for localizable strings.
    */
-    public var customLocalization: GiniLocalization?
+   public var customLocalization: GiniLocalization?


Suggested change

public var customLocalization: GiniLocalization?

public var customLocalization: GiniLocalization?

razvancapra added 4 commits January 15, 2025 13:30

feat(GiniHealthSDK): Show ingredient only in payment component, bank …

b3574bf

…selection and review screen based on configuration IPC-507

Merge branch 'main' into brand-ingredient-configuration

112cf56

fix(GiniHealthSDK): Fix tests after client configuration was added + …

fa51644

…small fixes

fix(GiniMerchantSDK): Fix GiniMerchantSDK tests after client's config…

5c51e85

… added in GiniInternalPaymentSDK

razvancapra self-assigned this Jan 15, 2025

razvancapra requested a review from zladzeyka January 15, 2025 13:12

razvancapra added 2 commits January 15, 2025 15:24

fix(GiniHealthSDK): Fix Sonar suggestions

36353c5

fix(GiniHealthSDK): Revert Sonar suggestion fix

e5d1222

zladzeyka requested changes Jan 20, 2025

View reviewed changes

fix(GinIHealthSDK): Fix review suggestions

2352a80

IPC-507

razvancapra requested a review from zladzeyka January 23, 2025 11:56

razvancapra added 2 commits January 30, 2025 11:05

Merge branch 'main' into brand-ingredient-configuration

ab75dcd

fix(GiniHealthSDKExample): Fix debug menu view after merge

dcf6d7c

razvancapra requested a review from igor-gini February 5, 2025 09:09

zladzeyka approved these changes Feb 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(GiniHealthSDK): Brand ingredient configuration #766

feat(GiniHealthSDK): Brand ingredient configuration #766

razvancapra commented Jan 15, 2025

zladzeyka left a comment

zladzeyka Jan 20, 2025

zladzeyka Jan 20, 2025

zladzeyka Jan 20, 2025

zladzeyka Jan 20, 2025

zladzeyka Jan 20, 2025

zladzeyka Jan 20, 2025

razvancapra Jan 22, 2025

zladzeyka Jan 20, 2025

zladzeyka Jan 20, 2025

razvancapra Jan 22, 2025

sonarqubecloud bot commented Jan 30, 2025

zladzeyka left a comment

zladzeyka Feb 6, 2025

	fetchAndConfigureClientConfiguration()
	fetchAndUpdateClientConfiguration()

	public var customLocalization: GiniLocalization?
	public var customLocalization: GiniLocalization?

feat(GiniHealthSDK): Brand ingredient configuration #766

Are you sure you want to change the base?

feat(GiniHealthSDK): Brand ingredient configuration #766

Conversation

razvancapra commented Jan 15, 2025

zladzeyka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jan 30, 2025

Quality Gate passed

zladzeyka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment