Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PP-777: Add Bank SDK version to upload metadata http header #753

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PP-777: Add Bank SDK version to upload metadata http header #753

wants to merge 3 commits into from

Conversation

igor-gini
Copy link
Contributor

No description provided.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
24.6% Duplication on New Code

See analysis details on SonarQube Cloud

@igor-gini igor-gini self-assigned this Dec 6, 2024
@zladzeyka zladzeyka self-requested a review December 11, 2024 13:14
zladzeyka
zladzeyka requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @igor-gini please find some suggestions 😇

...ibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Document+UploadMetadata.swift Show resolved Hide resolved
...ibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Document+UploadMetadata.swift Outdated Show resolved Hide resolved
BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Document.swift Outdated Show resolved Hide resolved
BankAPILibrary/GiniBankAPILibrary/Sources/GiniBankAPILibrary/Documents/Document.swift Outdated Show resolved Hide resolved
BankSDK/GiniBankSDK/Sources/GiniBankSDK/Core/GiniBankNetworkingScreenApiCoordinator.swift Outdated Show resolved Hide resolved
@igor-gini igor-gini force-pushed the PP-777-Add-Bank-SDK-version-to-upload-metadata-http-header branch from 1b22de6 to 54e23e9 Compare January 14, 2025 08:57
@igor-gini igor-gini requested a review from zladzeyka January 15, 2025 14:42
@igor-gini igor-gini requested a review from zladzeyka January 20, 2025 09:26
zladzeyka
zladzeyka approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@zladzeyka zladzeyka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @igor-gini looks good to me!

ValentinaIancu-Gini
ValentinaIancu-Gini approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@ValentinaIancu-Gini ValentinaIancu-Gini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @igor-gini looks good to me as well!

@igor-gini igor-gini force-pushed the PP-777-Add-Bank-SDK-version-to-upload-metadata-http-header branch from 4ff1b98 to 5b0c76d Compare January 29, 2025 14:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValentinaIancu-Gini ValentinaIancu-Gini ValentinaIancu-Gini approved these changes

@zladzeyka zladzeyka zladzeyka approved these changes

Assignees

@igor-gini igor-gini

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@igor-gini @zladzeyka @ValentinaIancu-Gini