PP-943: landscape orientation support android #653
+789
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oResultsScreen PP-945
…port-android' into PP-943-Landscape-orientation-support-android
|
This was referenced Jan 10, 2025
There was a problem hiding this comment.
[Request]
It looks good. Just some things to consider. Thank you!
- gc_fragment_onboading -> Layouts look differently in the code in landscape and portrait mode, make sure it is as intended. (I didn't check how it looks on the device)
- gc_fragment_onboading_page: scroll view is removed from the landscape mode. Make sure in small devices does not cause problems.
- gc_fragment_digital_invoice_onboading: scroll view is removed from the landscape mode. Make sure in small devices does not cause problems.
|
@abolfazlimahdi |
obaidgini
changed the base branch from
main
to
PM-142-Accessibility-base-branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged PP-948, PP-944 ,PP-954 into this branch, testing was not possible with separate branches because of forced portrait orientation. PP-948, PP-944 ,PP-954 are already reviewed and approved by @danicretu and @obaidgini.