Ipc 470 landscape mode for review screen #640
Conversation
|
…tActivity` IPC-470
…mentComponentBottomSheet` IPC-560
| xmlns:tools="http://schemas.android.com/tools" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="match_parent" | ||
| android:background="@color/ghs_light_07"> |
There was a problem hiding this comment.
Just wanted to know that: This color is behaving same for night and day mode, are we supporting both or it is same in designs for both modes?
| android:layout_width="match_parent" | ||
| android:layout_height="wrap_content" | ||
| tools:parentTag="androidx.constraintlayout.widget.ConstraintLayout"> | ||
| <androidx.constraintlayout.widget.ConstraintLayout |
There was a problem hiding this comment.
Can we please add spaces between the tags? Only this and the tag next to it, rest of the file you already added the spaces between tags. Thank you :)
There was a problem hiding this comment.
@danicretu Everything looks good to me 👌 , Just a small spaces related comment is added. Thank you!
|
No description provided.