PP 835 updating libraries #628
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…layout, view pager and material dependencies version [PP-835]
…ore and coroutine related dependencies version [PP-835]
…ted json library used with same version. [PP-835]
…st and downgrading bom version of compose because it needs some code changes [PP-835]
abolfazlimahdi
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Looks good. Thank you! Only two points:
- Can you please refactor the libs.versions file and extract the libraries that are added without separate versions like:
androidx-core-ktx = "androidx.core:core-ktx:1.14.0-alpha01" - It would be great to have a look at changes that come with major versions of Kotlin and AGP. We also want to notify our clients about upgrading these two libraries in the future.
…ke this file consistent [PP-835]
…layout, view pager and material dependencies version [PP-835]
…ore and coroutine related dependencies version [PP-835]
…ted json library used with same version. [PP-835]
…st and downgrading bom version of compose because it needs some code changes [PP-835]
[PP-835]
…PP-835-updating-libraries # Conflicts: # gradle/libs.versions.toml
|
abolfazlimahdi
approved these changes
Dec 10, 2024
obaidgini
force-pushed
the
PP-835-updating-libraries
branch
from
519b101 to
44164dd
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.