-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark #77
base: master
Are you sure you want to change the base?
Add benchmark #77
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #77 +/- ##
==========================================
+ Coverage 94.24% 94.78% +0.53%
==========================================
Files 2 2
Lines 139 115 -24
==========================================
- Hits 131 109 -22
+ Misses 5 3 -2
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Checking the raw logs, it seems even if I set permission for PR to write, it isn't taken into account. From reading around, it seems it would only switch it to write if it get merged into master first, but I am not certain of that. No idea how to tests this further at the moment. |
When running test and linter, there is no reason to keep going when a new head is pushed. So cancel past build to enable new build to start asap.
7f1fba0
to
92ad5cf
Compare
Seems you need to check your Settings > Actions > General > Workflow permissions, and make sure to enable read and write permissions for this action to actually work. |
This should help for #69 and #76 and future PR that could affect performance.