Fix triple clicking empty line and dragging #5068
Open
+20
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otomist
changed the title
mitchellh
requested changes
Jan 14, 2025
| @@ -2215,6 +2215,7 @@ pub const SelectLine = struct { | |||
| /// state changing a boundary. State changing is ANY state | |||
| /// change. | |||
| semantic_prompt_boundary: bool = true, | |||
| allow_empty_lines: bool = false, | |||
| // If we allow empty lines, we don't need to do any further checks. | ||
| if (opts.allow_empty_lines) { | ||
| return Selection.init(start_pin, end_pin, false); | ||
| } |
There was a problem hiding this comment.
This needs to be unit tested. Everything in Screen should be unit tested (for historical reasons some parts aren't but going forward we should be adding it it all)
| // that had no data, in this case recall selectLine with allow_empty_lines. | ||
| if (sel_ == null) { | ||
| sel_ = screen.selectLine(.{ .pin = click_pin, .allow_empty_lines = true }); | ||
| } |
There was a problem hiding this comment.
Use a labeled block to put all of this (line 3570 to here) in a const assignment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes core issue #4957. Adds a bool to
SelectLineallowing theselectLinefunction to select lines that are empty. When starting a triple selection on an empty line the initialselectLinereturns null because we don't see any characters, in this case we rerunselectLinebut short circuit with theallow_empty_lines. We need to runselectLinewith out allowing empty lines once because if there are characters on the line we don't want to select empty space.