fix: Ensure file paths are properly escaped during pasteboard paste operations

[AlexJuca]

This PR ensures file paths derived from pasteboard operations are properly escaped:

Before fix:

Attempting to cd into these paths rendered the following error: cd: too many arguments because the directory name includes spaces or special characters, which need to be handled correctly when running the cd command.

Screen.Recording.2025-01-13.at.23.55.23.video-converter.com.mp4

Afer fix

File paths are now properly escaped and we can correctly cd into these paths.

Screen.Recording.2025-01-13.at.23.58.00.video-converter.com.mp4

This change ensures Ghostty has the same behaviour as Iterm2.

[Mil0dV]

Ok so I don't know this code base enough to figure out if this also applies to linux (I searched and found bits of safepaste code, but I tested it, and it fails in exactly the same way.

So I'd say: why not also fix this for linux?

[AlexJuca]

Ok so I don't know this code base enough to figure out if this also applies to linux (I searched and found bits of safepaste code, but I tested it, and it seems to fail exactly like you described (vids won't load for me).

So I'd say: why not also fix this for linux?

@Mil0dV I don't know if this issue exists for Linux.

Can you reproduce the issue on Linux? That would be nice.

Unfortunately, I can't because I don't use Linux, and the fix will likely involve very platform-specific changes.

[Mil0dV]

@AlexJuca ah my edit and your reply crossed eachother. Yes, I reproduced this on linux. Shouldn't the same Ghostty.Shell.escape() also work there, if the right file is found to insert it?

[AlexJuca]

@AlexJuca ah my edit and your reply crossed eachother. Yes, I reproduced this on linux. Shouldn't the same Ghostty.Shell.escape() also work there, if the right file is found to insert it?

@Mil0dV The Ghostty.Shell.escape() function is a Swift only API, so it won't work on Linux.

[jcollie]

This was recently added to the Zig code:

ghostty/src/os/shell.zig

Lines 9 to 41 in d1fd22a

	pub fn ShellEscapeWriter(comptime T: type) type {
	return struct {
	child_writer: T,
	fn write(self: *ShellEscapeWriter(T), data: []const u8) error{Error}!usize {
	var count: usize = 0;
	for (data) |byte| {
	const buf = switch (byte) {
	'\\',
	'"',
	'\'',
	'$',
	'`',
	'*',
	'?',
	' ',
	'|',
	=> &[_]u8{ '\\', byte },
	else => &[_]u8{byte},
	};
	self.child_writer.writeAll(buf) catch return error.Error;
	count += 1;
	}
	return count;
	}
	const Writer = std.io.Writer(*ShellEscapeWriter(T), error{Error}, write);
	pub fn writer(self: *ShellEscapeWriter(T)) Writer {
	return .{ .context = self };
	}
	};
	}

It's not exposed to macOS at the moment though.