Skip to content

Commit

Permalink
fix(Metal): always render explicit background colors fully opaque (#5335
Browse files Browse the repository at this point in the history
)

This fixes a regression introduced by the rework of this area before
during the color space changes (#4913). It seems like the original
intent of this code was the behavior it regressed to, but it turns out
to be better like this.
  • Loading branch information
mitchellh authored Jan 24, 2025
2 parents 95327bf + 78790f6 commit 4b82e0a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions src/renderer/Metal.zig
Original file line number Diff line number Diff line change
Expand Up @@ -2672,9 +2672,8 @@ fn rebuildCells(
// Cells that are reversed should be fully opaque.
if (style.flags.inverse) break :bg_alpha default;

// Cells that have an explicit bg color, which does not
// match the current surface bg, should be fully opaque.
if (bg != null and !rgb.eql(self.background_color orelse self.default_background_color)) {
// Cells that have an explicit bg color should be fully opaque.
if (bg_style != null) {
break :bg_alpha default;
}

Expand Down

0 comments on commit 4b82e0a

Please sign in to comment.