Skip to content

Commit

Permalink
Fix typo in api export and remove pylint pragmas (#48)
Browse files Browse the repository at this point in the history
Co-authored-by: TheByronHimes <[email protected]>
  • Loading branch information
TheByronHimes and TheByronHimes authored Jun 4, 2024
1 parent d857b58 commit d74e4fa
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .pyproject_generation/pyproject_custom.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[project]
name = "ghga_service_commons"
version = "3.1.4"
version = "3.1.5"
description = "A library that contains common functionality used in services of GHGA"
readme = "README.md"
authors = [
Expand Down
2 changes: 1 addition & 1 deletion examples/api/hello_world_web_server/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from ghga_service_commons.api import run_server
from ghga_service_commons.utils.utc_dates import assert_tz_is_utc

from .api import app # noqa: F401 pylint: disable=unused-import
from .api import app # noqa: F401
from .config import get_config


Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ classifiers = [
"Intended Audience :: Developers",
]
name = "ghga_service_commons"
version = "3.1.4"
version = "3.1.5"
description = "A library that contains common functionality used in services of GHGA"
dependencies = [
"pydantic >=2, <3",
Expand Down
4 changes: 2 additions & 2 deletions src/ghga_service_commons/api/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@

"""Functionality building HTTP APIs using FastAPI."""

from ghga_service_commons.api.api import ( # noqa: F401
from ghga_service_commons.api.api import (
ApiConfigBase,
configure_app,
run_server,
)

__all__ = ["ApiCOnfigBase", "configure_app", "run_server"]
__all__ = ["ApiConfigBase", "configure_app", "run_server"]
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ def configure_exception_handler(app: FastAPI) -> None:

@app.exception_handler(HttpException)
def exception_handler(
request: Request, # pylint: disable=unused-argument
request: Request,
# (The above is required by the corresponding FastAPI interface but not used here)
exc: HttpException,
) -> JSONResponse:
Expand Down
2 changes: 0 additions & 2 deletions tests/integration/test_httpyexpect_client.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ def test_typical_client_usage(

def test_compatibility_with_httpx():
"""Make sure that our Response protocol is compatible with the httpx library."""
# pylint: disable=import-outside-toplevel
from httpx import Response as HttpxResponse

httpx_response = HttpxResponse(status_code=200, content=b'{"hello": "world"}')
Expand All @@ -116,7 +115,6 @@ def test_compatibility_with_httpx():

def test_compatibility_with_requests():
"""Make sure that our Response protocol is compatible with the requests library."""
# pylint: disable=import-outside-toplevel
from requests import Response as RequestsResponse

requests_response = RequestsResponse()
Expand Down

0 comments on commit d74e4fa

Please sign in to comment.