-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bucket_id propagation #62
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I gave you general questions on Slack, but otherwise no issues. A couple minor things you might change first.
Co-authored-by: Byron Himes <[email protected]>
Co-authored-by: Byron Himes <[email protected]>
Co-authored-by: Byron Himes <[email protected]>
Pull Request Test Coverage Report for Build 11127679786Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The remaining params/vars need to be updated too
bucket_id
to output metadata models, which is populated from config by looking at availableobject_storages
and theselected_storage_alias
selected_bucket_id
config parameter toIngestConfig
as fallback to populatebucket_id
values in old metadatabucket_id
fallback during ingest