Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket_id propagation #62

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Fix bucket_id propagation #62

merged 10 commits into from
Oct 2, 2024

Conversation

mephenor
Copy link
Member

  • Added bucket_id to output metadata models, which is populated from config by looking at available object_storages and the selected_storage_alias
  • Added selected_bucket_id config parameter to IngestConfig as fallback to populate bucket_id values in old metadata
  • Minor version bump due to new config option
  • Added code to populate bucket_id fallback during ingest
  • Added logging at some branching points during ingest
  • Updated some missing information to readme

dontseyit
dontseyit previously approved these changes Oct 1, 2024
TheByronHimes
TheByronHimes previously approved these changes Oct 1, 2024
Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave you general questions on Slack, but otherwise no issues. A couple minor things you might change first.

README.md Outdated Show resolved Hide resolved
src/ghga_datasteward_kit/models.py Outdated Show resolved Hide resolved
src/ghga_datasteward_kit/models.py Outdated Show resolved Hide resolved
Co-authored-by: Byron Himes <[email protected]>
@coveralls
Copy link

coveralls commented Oct 1, 2024

Pull Request Test Coverage Report for Build 11127679786

Details

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.8%) to 77.169%

Totals Coverage Status
Change from base Build 11065694685: 0.8%
Covered Lines: 845
Relevant Lines: 1095

💛 - Coveralls

Copy link
Member

@TheByronHimes TheByronHimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The remaining params/vars need to be updated too

src/ghga_datasteward_kit/models.py Outdated Show resolved Hide resolved
src/ghga_datasteward_kit/models.py Outdated Show resolved Hide resolved
tests/fixtures/ingest.py Outdated Show resolved Hide resolved
@mephenor mephenor merged commit 9e0b8df into main Oct 2, 2024
6 checks passed
@mephenor mephenor deleted the fix/bucket_id_propagation branch October 2, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants