-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support both file_secret and secret_id based paths #29
Conversation
Pull Request Test Coverage Report for Build 6696361678
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could not really check in depth.
Co-authored-by: Christoph Zwerschke <[email protected]>
Co-authored-by: Christoph Zwerschke <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this was a massive rewrite. I could just do a shallow review but did not found major issues. However, would need much more time to go into more depth. Could you maybe help by highlighting which parts were rewritten and which parts mostly moved into different files?
Regarding tests, since this is becoming a quite massive codebase that is difficult to keep an overview (and to help answer your question about whether everything was tested correctly), maybe it would be good to try to approach 100% coverage. Some parts really do not need coverage, you can ignore them by configuring the coverage tools.
What do you think, would 100% coverage give you a better feel?
All requested changes have been addressed in the lastest commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice thank you
Old code paths and related classes dealing with output_metadata including the plain text file secret are now prefixed with legacy.
Refactored s3_upload into a subpackage to keep some semblance of sanity.
Added missing object storage cleanup when checksum validation fails after re-downloading file for validation.
Added secret_ingest URL and public key options to support file secret exchange directly after upload.
Token for communication on that path is read from the same location as for the file ingest functionality before, i.e. the same token is used for both new FIS endpoints.
Please tell me if there are some tests missing that should be included, lost quite a bit of time here and probably missed one or two smaller issues.
As this repo does not track the microservice template, we probably should also have a refactoring backlog entry to move this to ruff, pydantic v2 and our pip lock setup.