Refactor

jsf/parser.py

@@ -42,7 +42,7 @@ def __init__(
             }
         ),
         initial_state: Dict[str, Any] = MappingProxyType({}),
-        allow_none_optionals: float = 0.0,
+        allow_none_optionals: float = 0.5,
     ):
         self.root_schema = schema
         self.definitions = {}

jsf/schema_types/base.py

@@ -33,7 +33,7 @@ class BaseSchema(BaseModel):
     provider: Optional[str] = Field(None, alias="$provider")
     set_state: Optional[Dict[str, str]] = Field(None, alias="$state")
     is_nullable: bool = False
-    allow_none_optionals: float = 1.0
+    allow_none_optionals: float = 0.5
 
     @classmethod
     def from_dict(cls, d: Dict):

jsf/schema_types/number.py

@@ -34,7 +34,7 @@ def generate(self, context: Dict[str, Any]) -> Optional[float]:
                 _max = self.maximum
 
             return float(
-                step * random.uniform(math.ceil(float(_min) / step), math.floor(float(_max) / step))
+                step * random.randint(math.ceil(float(_min) / step), math.floor(float(_max) / step))
             )
 
     def model(self, context: Dict[str, Any]):

jsf/schema_types/object.py

@@ -33,11 +33,9 @@ def from_dict(cls, d: dict):
         return Object(**d)
 
     def should_keep(self, property_name: str) -> bool:
-        if random.uniform(0, 1) > self.allow_none_optionals or (
-            isinstance(self.required, list) and property_name in self.required
-        ):
+        if isinstance(self.required, list) and property_name in self.required:
             return True
-        return random.uniform(0, 1) < 0.5
+        return random.uniform(0, 1) > self.allow_none_optionals
 
     def generate(self, context: Dict[str, Any]) -> Optional[Dict[str, Any]]:
         try: