Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sample: maintain token count in penalty sampler context #9922

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kylo5aby
Copy link
Contributor

Copy link
Owner

@ggerganov ggerganov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also reset token_count in llama_sampler_penalties_reset()

@kylo5aby
Copy link
Contributor Author

Need to also reset token_count in llama_sampler_penalties_reset()

Resolved.

Comment on lines 1404 to 1406
if (ctx->prev.size() >= (size_t) ctx->penalty_last_n) {
if (--ctx->token_count[ctx->prev.front()] == 0) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an assert here would be worth it as a sanity check:

Suggested change
if (ctx->prev.size() >= (size_t) ctx->penalty_last_n) {
if (--ctx->token_count[ctx->prev.front()] == 0) {
if (ctx->prev.size() >= (size_t) ctx->penalty_last_n) {
assert(ctx->token_count.at(ctx->prev.front()) > 0);
if (--ctx->token_count[ctx->prev.front()] == 0) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants