Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly Deal with Timeouts #7030

Open
wants to merge 9 commits into
base: trunk
Choose a base branch
from
Open

Properly Deal with Timeouts #7030

wants to merge 9 commits into from

Conversation

cwfitzgerald
Copy link
Member

@cwfitzgerald cwfitzgerald commented Jan 30, 2025 •
edited
Loading

Connections

Close #3601
Close #4589

Description
Describe what problem this is solving, and how it's solved.

Testing
Explain how this change is tested.

Checklist

  • Run cargo fmt.
  • Run taplo format.
  • Run cargo clippy. If applicable, add:
    • --target wasm32-unknown-unknown
  • Run cargo xtask test to run tests.
  • Add change to CHANGELOG.md. See simple instructions inside file.

@cwfitzgerald cwfitzgerald requested review from crowlKats and a team as code owners January 30, 2025 02:40
@cwfitzgerald cwfitzgerald marked this pull request as draft January 30, 2025 05:09
@cwfitzgerald cwfitzgerald marked this pull request as ready for review January 30, 2025 20:19
@Wumpf Wumpf self-requested a review January 31, 2025 09:40
@teoxoy
Copy link
Member

teoxoy commented Jan 31, 2025

I looked at the wgpu-core changes and they looked good to me. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crowlKats crowlKats Awaiting requested review from crowlKats crowlKats is a code owner

@Wumpf Wumpf Awaiting requested review from Wumpf

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@cwfitzgerald @teoxoy