[core] Use higher level LoadOp,StoreOp #6785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagudev <[email protected]>
Signed-off-by: sagudev <[email protected]>
|
cc @ErichDonGubler there are some C related changes, cc @teoxoy for telling me if I went to far. |
Signed-off-by: sagudev <[email protected]>
sagudev
force-pushed
the
higherviewcore
branch
from
25d371d to
cee06f0
Compare
teoxoy
reviewed
Dec 19, 2024
teoxoy
approved these changes
Dec 19, 2024
Signed-off-by: sagudev <[email protected]>
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 21, 2024
Signed-off-by: sagudev <[email protected]>
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 21, 2024
{"fail_fast": false, "matrix": [{"name": "WebGPU CTS", "workflow": "linux", "wpt_layout": "2020", "profile": "production", "unit_tests": false, "bencher": false, "wpt_args": "_webgpu"}]}
cwfitzgerald
approved these changes
Dec 23, 2024
|
Merging for expediency - @crowlKats if something is wrong, shout later. |
sagudev
added a commit
to sagudev/servo
that referenced
this pull request
Dec 30, 2024
gfx-rs/wgpu@0f5f058 Most notable change is gfx-rs/wgpu#6785 Signed-off-by: sagudev <[email protected]>
3 tasks
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 2, 2025
* Update wgpu gfx-rs/wgpu@0f5f058 Most notable change is gfx-rs/wgpu#6785 Signed-off-by: sagudev <[email protected]> * Remove silencing of wgpu logs I fixed this in upstream: gfx-rs/wgpu#6817 Signed-off-by: Samson <[email protected]> --------- Signed-off-by: sagudev <[email protected]> Signed-off-by: Samson <[email protected]>
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Jan 2, 2025
* Update wgpu gfx-rs/wgpu@0f5f058 Most notable change is gfx-rs/wgpu#6785 Signed-off-by: sagudev <[email protected]> * Remove silencing of wgpu logs I fixed this in upstream: gfx-rs/wgpu#6817 Signed-off-by: Samson <[email protected]> --------- Signed-off-by: sagudev <[email protected]> Signed-off-by: Samson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#6753 (comment)
Description
In f5bb3f7 I moved
Operations,LoadOp,StoreOpfor wgpu to wgt, so we can use those abstractions in 5542c3c forResolvedPassChannel. Then in fa4a5ed I movedPassChannelto also usewgt::LoadOp,wgt::StoreOp; thus removing oldLoadOp/StoreOp. We still need somewhatPassChannelin core to be able to express all wrong stuff JS user can do, but when we do all validation we are back to wgpu's abstraction (which prevents all such misuses). It would be interesting future project to avoid some validation in core by passing those safer/strict types directly to core. In the future, hal could also start using higher abstraction for LoadOp.Changes in servo needed for this PR: sagudev/servo@6125931 (this will be useful for firefox).
Testing
No behaviour change is expected, CTS run in servo confirms that (note that CRASH in
webgpu:shader,execution,expression:*are know problem in servo due to cyclic imports), there are also some existing tests covering this.Checklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.