-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
first bits of security content added #8
base: main
Are you sure you want to change the base?
Conversation
bump @seankross 🙏🏽 |
### Examples | ||
|
||
We strongly encourage all exported, user-facing functions, to have examples. However, when PII/PHI data is a crucial part of an example for a function/class/etc. we need to take extra precautions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that anything in the WILDS would have PII/PHI data. If data is de-identified, it's not considered to be PHI.
I am not sure how I am going to do data-as-a-product on the CARDS platform and if would be possible/advisable to create R packages that someone live just on there. I think that is the only time that we would have PHI in an R package though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks very much @monicagerber ! Do you think we just remove this comment about PII/PHI data in examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely nothing in WILDS should contain PII/PHI in the package itself, but I imagine several WILDS packages will touch/transmit PII/PHI.
## Data | ||
|
||
Software created in the WILDS may touch PII/PHI data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that instead of writing sensitive data handling practices here we should link to the sciwiki or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. Are you thinking we just remove this chapter? Or keep the chapter but simply link out to sciwiki/other resources with very little text in the chapter itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep it and link out. The we could have sections like "how to securely integrate [a WILDS thing] with [a service discussed on sciwiki]"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
This chapter is on hold for now ... |
Any thoughts on the first bits of content for the security chapter?
This is a bit different from the other chapters in that i imagine we want to think harder about this chapter given where we work.
There's some half finished thoughts on purpose in here for your feedback. thanks!
We're only building the book for congtent on
main
, but you can pull this repo down, then runmake preview
#6