Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent reparenting a task to itself #1149

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

gycsaba96
Copy link
Contributor

It was possible to reparent a task to itself using drag-and-drop. TaskPane.check_parent now checks if the drop target is the same task we are moving.

Steps to reproduce the bug:

  1. Pick a task and start dragging it over another task.
  2. Move it back over itself, and drop it.
  3. Observe as the task disappears instead of not doing anything.

By repeating these steps, you can make all of your tasks disappear. They are still in the gtg_data.xml, but there is no way accesing them.

TaskPane.check_parent now checks if the drop target is the same
task we are moving.
@diegogangl
Copy link
Contributor

LGTM, thanks!

@diegogangl diegogangl merged commit fe71813 into getting-things-gnome:master Oct 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants