Simple typing fixes for tasks.py #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use the _Element class instead of the Element factory for typing - expect None values often used by lxml - rename 'title' setter to 'set_title' - fix default value for duplicate_cb - other minor fixes
diegogangl
added
enhancement
maintainability
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main changes are as follows:
_Elementclass instead of theElementfactory for typingNonevalues often used by lxmltitlesetter toset_titleduplicate_cbThis fixes every typing error mypy indicates except for the signature errors of some overrides. (I want to investigate the saved searches before looking into those.)