Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sensitivity of start button #1114

Merged
merged 3 commits into from
Jul 18, 2024

Conversation

diegogangl
Copy link
Contributor

Fixes #1004

Copy link
Contributor

@SqAtx SqAtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I don't really understand the GHA error. It's failing on python -m pip install --upgrade pip and not on our actual tests. So, re-running it would probably be fine?

GTG/gtk/browser/sidebar.py Show resolved Hide resolved
GTG/gtk/browser/main_window.py Outdated Show resolved Hide resolved
Lets us toggle the start tomorrow button when changing tags or
saved searches
@diegogangl
Copy link
Contributor Author

Thanks for the reviews! The tests seem to be doing ok now

@diegogangl diegogangl merged commit 9d47d54 into getting-things-gnome:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Start Tomorrow" button and menubutton sensitivity state is broken
2 participants