Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to dismiss search bar #1106

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

diegogangl
Copy link
Contributor

Pressing ESC now closes the search bar again. Good times

fixes #1003

@nekohayo
Copy link
Member

A quickie glance at the diff tells me that the Ctrl+F key would still clear the search instead of refocusing; would you want to address #952 at the same time in this MR in the same commit, or better to keep it separate?

@diegogangl
Copy link
Contributor Author

Best to keep the PRs short and sweet for now

@diegogangl diegogangl merged commit 2733df0 into getting-things-gnome:master Jun 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Escape key does not allow dismissing / closing the searchbar
2 participants