Always show tags with zero tasks #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'TagEmptyFilter' checks for the correct 'self.pane' values and considers the newly introduced 'show_zero' field. This fixes GitHub issue getting-things-gnome#1007
diegogangl
added this to the 0.7: "Getting things Gradius — Destroy the core!" milestone
|
Ah yes, I recently hit in that difference in pane names again in another branch. We should fix that in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1007
The anomaly was caused by a lucky bug.
TagEmptyFilterwas checking for the wrongself.panevalues except whenSidebar.__init__created the object, thus filtering the tags with zero tasks only after startup.Now,
TagEmptyFilterchecks for the correctself.panevalues and considers the newly introducedshow_zerofield. (This field could be used in the future to show and hide tags with zero tasks.)