Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tests from checks #1090

Merged
merged 1 commit into from
Apr 21, 2024

Conversation

diegogangl
Copy link
Contributor

Running tests locally has become a bit more involved recently. We can keep them out of "make check" for now, so that we can at least get some basic style checks running again.

Fixes #838

(actually the error in that issue was fixed with the new core, but there was a new error related to run-tests)

Running tests locally has become a bit more involved recently.
We can keep them out of "make check" for now, so that we can at least
get some basic style checks running again.

Fixes getting-things-gnome#838
@diegogangl diegogangl added the bug label Apr 16, 2024
@nekohayo nekohayo added the maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers label Apr 19, 2024
Copy link
Contributor

@SqAtx SqAtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
As I mentioned in #1065, it looks like the functionality of the Makefile is going to move to pre-commit and meson, so we can probably remove it eventually? We'll have to update the documentation that references it.

@diegogangl
Copy link
Contributor Author

Hmm yeah maybe. I don't know enough about Meson to tell if all the targets in the make file are doable in there TBH

@diegogangl diegogangl merged commit 42205d0 into getting-things-gnome:master Apr 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug maintainability Automated tests suite, tooling, refactoring, or anything that makes it easier for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make check fails on a permissions error to nonexistent config file
3 participants