Rework About dialog #1066
Merged
Rework About dialog #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilSkeleton
force-pushed
the
fix-about-dialog
branch
5 times, most recently
from
db6c39d
to
eb968ec
Compare
|
Wouldn't it be better to name the "Support" button something like "Dev chatroom" (or leave that link up to the website)? I'm concerned that the word "support" might lead to some subconscious expectations from some users ;) |
|
Sure |
TheEvilSkeleton
force-pushed
the
fix-about-dialog
branch
from
eb968ec
to
11cdc68
Compare
TheEvilSkeleton
force-pushed
the
fix-about-dialog
branch
from
11cdc68
to
2da8ac5
Compare
|
LGTM in general. I would remove the "donate" button though, at least until we make a GTG account in Liberapay and/or find a way to split donations among the top contributors |
This makes a few changes and additions: - This adds a new dependency on libportal. It's used to detect if it's sandboxed. - Various `GtkButton`s are added to provide external links. - The Credits section has been reworked to prevent the about dialog from increasing. - New System section was added to help users copy and paste system information for troubleshooting purposes. - The about dialog is now a modal window.
TheEvilSkeleton
force-pushed
the
fix-about-dialog
branch
from
2da8ac5
to
51933c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes and additions:
GtkButtons are added to provide external links.Screenshots: