-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the test suite #1036
Fix the test suite #1036
Conversation
e61007d
to
5339e3c
Compare
080a86b
to
31fe22f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't run the tests locally right now, but if this diff takes us to a point where individual tests are failing instead of import errors etc, this is a step in the right direction :)
It doesn't block the current changes, but I'm still getting import failures when running the tests locally:
(and 2 more)
Anyway, I can fix that separately. |
tldrInstall the project in a prefix of your choice using meson and add the directory with the installed package to PYTHONPATH. Run the tests with The lenghty explanationYeah... running locally is somewhat more complicated since GTG uses Meson to build its sources. Configuring
|
d628fa5
to
a092ae2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 minor comments but other than that, LGTM :)
Happy to have a green test run again! Thanks for your work there. I got it running locally as well. We'll add something to the README about that, because it's not obvious that we need to run Meson before we can run the tests.
Remove refactoring changes.
These only tested the design of the old weakly coupled attributes api. It has been completely replaced an removed from the core.
Remove tree testing since Saved searches are not representing hierarchies anymore.
This annotates the method as `staticmethod`, so it can be used and tested again without requiring an instance of `ModifyTagsDialog`.
Thank you for working on this! Great to see the checks green again :) |
This is a follow up on #999
The goal was to get the CI tests running again and later the scope was extended to fix the whole test suite.