draft(subscriptions): Introduce RPCSubscriptionData class #6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shruthilayaj
changed the title
… into shruthi/feat/introduce-rpc-subscription-class
volokluev
reviewed
Oct 17, 2024
Comment on lines
+123
to
+130
| @dataclass(frozen=True, kw_only=True) | ||
| class RPCSubscriptionData(SubscriptionData): | ||
| """ | ||
| Represents the state of an RPC subscription. | ||
| """ | ||
|
|
||
| table_request: str | ||
|
|
There was a problem hiding this comment.
- the table_request is bytes, not a string
- we should be storing the name of the endpoint and the version of it. The API will evolve and we need to be able to change the model along with it
volokluev
reviewed
Oct 18, 2024
|
|
||
| table_request: str | ||
|
|
||
| def build_request( |
There was a problem hiding this comment.
returning a snuba Request object here does not make sense. The RPC implementations will build whatever requests are necessary and execute them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, I want to make sure this is will do what I want it to do