ref(alerts): use registry pattern for EventAttributeCondition attempt 2 #79456
+302
−158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #79456 +/- ##
==========================================
+ Coverage 78.31% 78.32% +0.01%
==========================================
Files 7137 7137
Lines 315317 315391 +74
Branches 51529 51545 +16
==========================================
+ Hits 246942 247036 +94
+ Misses 61899 61886 -13
+ Partials 6476 6469 -7 |
saponifi3d
approved these changes
Oct 21, 2024
| else: | ||
| try: | ||
| attribute_values = attr_handler.handle(path, event) | ||
| except KeyError: |
There was a problem hiding this comment.
🎉 nice that this refactor separates this error handling vs before - it's a lot simpler to reason about the key error.
for extra credit, i think it might be even nicer for us to update the AttributeHandler implementations so each individual handler works as intended (either returning [] or the correct value)
There was a problem hiding this comment.
i'll add that and still have the KeyError, but capture the exception since we know it actually shouldn't happen
| @@ -365,6 +375,24 @@ def test_error_handled_not_defined(self): | |||
| ) | |||
| self.assertDoesNotPass(rule, event) | |||
|
|
|||
| @patch("sentry.eventstore.models.get_interfaces", return_value={}) | |||
There was a problem hiding this comment.
thanks for adding more test cases to cover this.
This reverts commit da8f866.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed a
KeyErrorcheck when I merged the first time in #79435. Putting it back should allow this to deploy now. Added tests that fail without the check.