Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): add proj feature observer #79455

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

michellewzhang
Copy link
Member

followup to

add a feature observer for calls to project.features.includes(...) similar to the one we have for organization.features.includes(...).

this one behaves the same way as the old one. i refactored out the buffer updating code so we can reuse it for both cases. the flag evaluations for both org + project are pushed into the same flag queue, which is already being used in the beforeSend in initializeSdk.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 21, 2024
@michellewzhang michellewzhang marked this pull request as ready for review October 21, 2024 21:21
@michellewzhang michellewzhang requested a review from a team as a code owner October 21, 2024 21:21
@michellewzhang michellewzhang requested review from ryan953 and a team October 21, 2024 21:22
@getsentry getsentry deleted a comment from codecov bot Oct 21, 2024
@michellewzhang michellewzhang removed the request for review from a team October 21, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant