Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code-mappings): Add code mapping details to dropdown #79426

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(code-mappings): Add code mapping details to dropdown #79426

wants to merge 1 commit into from
+13 −4

Conversation

jangjodi
Copy link
Member

@jangjodi jangjodi commented Oct 21, 2024 •
edited
Loading

Add source code root and stack trace root to code mapping details dropdown
May want to make this prettier later, but gets the job done for now

Before:
Screenshot 2024-10-21 at 11 33 27 AM
After:
Screenshot 2024-10-21 at 11 32 05 AM

fixes #79410

@jangjodi jangjodi requested a review from a team as a code owner October 21, 2024 16:57
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 21, 2024
armenzg
armenzg approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@armenzg armenzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good turnaround! 🎉

Please add a screenshot with the before and after in the description.

@jangjodi
Copy link
Member Author

Good turnaround! 🎉

Please add a screenshot with the before and after in the description.

Thanks! I've added screenshots

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armenzg armenzg armenzg approved these changes

@scttcper scttcper scttcper approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show more information about code mapping in Add Code Owner File modal
3 participants
@jangjodi @armenzg @scttcper