ref(onboarding): Tweak sidebar code for loader script #79421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
priscilawebdev
commented
Oct 21, 2024
Comment on lines
+343
to
+345
| display: flex; | ||
| flex-direction: column; | ||
| gap: ${space(1)}; |
There was a problem hiding this comment.
adding this minor fix here too.
Before
After
Bundle ReportChanges will increase total bundle size by 30.97MB (100.0%) ⬆️
|
michellewzhang
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users may become confused if they have instrumented their SDK using the loader script and later encounter the following:
To address this, we are making the 'HTML Templates' option the default one, aligning it with how we display the Loader Script during onboarding. Additionally, we are adding '(Loader Script)' as a prefix to clarify its use.
We do not completely name it "Loader Script" because old users might not be familiar with this term.
Preview
closes #79183