Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(dashboards): Remove feature flag for Big Number Equations (frontend) #79420

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

ref(dashboards): Remove feature flag for Big Number Equations (frontend) #79420

wants to merge 7 commits into from

Conversation

harshithadurai
Copy link
Member

@harshithadurai harshithadurai requested a review from a team as a code owner October 21, 2024 16:19
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Oct 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

@harshithadurai harshithadurai changed the title ref(dashboards): Remove feature flag for Big Number Equations ref(dashboards): Remove feature flag for Big Number Equations (frontend) Oct 21, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 21, 2024

Bundle Report

Changes will increase total bundle size by 30.97MB (100.0%) ⬆️⚠️, exceeding the configured threshold of 5%.

Bundle name Size Change
app-webpack-bundle-array-push 30.97MB 30.97MB (100%) ⬆️⚠️

@harshithadurai
Copy link
Member Author

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Only removing frontend feature flags ^ (Reverted the backend changes)

narsaynorath
narsaynorath approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@narsaynorath narsaynorath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narsaynorath narsaynorath narsaynorath approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshithadurai @narsaynorath