Add QueryStats and QueryMetadata to TraceItemTableResponse #51
+30
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update proto/sentry_protos/snuba/v1/endpoint_trace_item_table.proto to include optional QueryStats and QueryMetadata fields in TraceItemTableResponse - Modify proto/sentry_protos/snuba/v1/request_common.proto to define QueryStats and QueryMetadata message structures These changes allow for more detailed query execution information to be included in responses, enhancing observability and debugging capabilities.
nachivrn
commented
Oct 19, 2024
| @@ -21,6 +21,7 @@ message TraceItemTableRequest { | |||
| uint32 limit = 6; | |||
| PageToken page_token = 7; | |||
| repeated VirtualColumnContext virtual_column_contexts = 8; | |||
| bool debug = 10; | |||
There was a problem hiding this comment.
Debug flag will be used to add QueryStats and QueryMetadata in the response
There was a problem hiding this comment.
This should go in the RequestMeta object so it can be generally available.
evanh
reviewed
Oct 21, 2024
| @@ -39,4 +40,6 @@ message TraceItemColumnValues { | |||
| message TraceItemTableResponse { | |||
| repeated TraceItemColumnValues column_values = 1; | |||
| PageToken page_token = 2; | |||
| optional QueryStats query_stats = 3; | |||
| optional QueryMetadata query_metadata = 4; | |||
There was a problem hiding this comment.
I would put both of these objects inside another object, so that you only have to add one field to the response instead of two.
There was a problem hiding this comment.
these should also be repeated because there could be many queries in one request
| @@ -21,6 +21,7 @@ message TraceItemTableRequest { | |||
| uint32 limit = 6; | |||
| PageToken page_token = 7; | |||
| repeated VirtualColumnContext virtual_column_contexts = 8; | |||
| bool debug = 10; | |||
There was a problem hiding this comment.
This should go in the RequestMeta object so it can be generally available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add QueryStats and QueryMetadata to TraceItemTableResponse