-
-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAUI] Session Replay #3882
base: main
Are you sure you want to change the base?
[MAUI] Session Replay #3882
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3882 +/- ##
==========================================
- Coverage 75.73% 75.33% -0.40%
==========================================
Files 357 389 +32
Lines 13466 14226 +760
Branches 2671 2860 +189
==========================================
+ Hits 10198 10717 +519
- Misses 2593 2815 +222
- Partials 675 694 +19 ☔ View full report in Codecov by Sentry. |
thank you so much for opening this PR!
We don't have recording support for those platforms yet. MacCatalyst might work since it's based on UIKit like iOS. @brustolin any idea how hard/easy to get it working? Windows would require a new recording implementation. @vaind investigated this briefly and iirc there's a path using Win32 APIs but we don't have it on the roadmap yet. One challenge here is exposing the masking API based on MAUI components in a way that translates to the native controls. So tagging folks who know best for review and tips: @krystofwoldrich @vaind @romtsn @brustolin |
MacCatalyst is an iOS app running on the Mac. It should be working already. For MacOs app, I believe the change will be minimal to make it work. |
if MAUI uses native controls, don't bother looking at Flutter, it has it's own capture and masking. RN would be the one to replicate here. |
Starting this PR with some of the iOS bits for #2136.
I hope to tackle the below in the coming days but wanted to start gathering as much feedback as possible -- I'm still fairly new to the codebase.
TODO:
Questions:
windows
/maccatalyst
?Demo (iOS Simulator)