fix: sdk name for native on android #3682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
requested review from
bitsandfoxes and
jamescrosswell
as code owners
| @@ -167,7 +167,7 @@ private static void InitSentryAndroidSdk(SentryOptions options) | |||
| o.EnableExternalConfiguration = false; | |||
| o.EnableDeduplication = false; | |||
| o.AttachServerName = false; | |||
| o.NativeSdkName = "sentry.native.dotnet"; | |||
| o.NativeSdkName = "sentry.native.android.dotnet"; | |||
There was a problem hiding this comment.
I take it this doesn't address whatever the more fundamental problem in #3654?
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- sdk name for native on android ([#3682](https://github.com/getsentry/sentry-dotnet/pull/3682))If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We append
.platformwhen 'wrapping' another SDK.sentry.nativeon Android, because of its custom unwinder and other significant changes (it's also built through sentry-java repo). Has a different SDK name:https://github.com/getsentry/sentry-native/blob/b555a978986f882abb3161bd1c848339f9a2cc1a/include/sentry.h#L28
Resolves: