Fixes "Failed to persist session" error on iOS #3655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3653
Ideally we'd be able to reproduce this in a unit test to prevent a regression.
Regardless, it looks like there might be a timing issue where sometimes the writer tries to do something with the file after
File.Dispose()
has been called. I've moved the writer inside the try block to ensurewriter.Dispose()
is called beforefile.Dispose()
, which should avoid the problem.