Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): Add warning message for Angular default Change Detection Strategy #11604

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 17, 2024

Add a warning message for Angular as it can break customer sites (or lead to performance problems) when using the default change detection strategy due to their monkeypatching of globals (Zone.js)

…n Strategy

Add a warning message for Angular as it can break customer sites (or lead to performance problems) when using the default change detection strategy due to their monkeypatching of globals (Zone.js)
Copy link

vercel bot commented Oct 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:20pm
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 9:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Oct 21, 2024 9:20pm

@billyvg billyvg requested review from lizokm, jas-kas, a team and bruno-garcia October 17, 2024 17:23
Copy link
Contributor

@lizokm lizokm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

docs/platforms/javascript/common/session-replay/index.mdx Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 21, 2024

Bundle Report

Changes will decrease total bundle size by 19 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 7.52MB 10 bytes (-0.0%) ⬇️
sentry-docs-edge-server-array-push 257.08kB 3 bytes (-0.0%) ⬇️
sentry-docs-client-array-push 6.44MB 6 bytes (-0.0%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants