Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deserialize SentryRequest #4784

Merged

Conversation

philipphofmann
Copy link
Member

Add Decodable/Deserializing of SentryRequest.

#skip-changelog

Add Decodable/Deserializing of SentryRequest.
Copy link

github-actions bot commented Feb 3, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9203218

Copy link

github-actions bot commented Feb 3, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1209.78 ms 1242.57 ms 32.79 ms
Size 22.31 KiB 800.11 KiB 777.80 KiB

Baseline results on branch: feat/deserializing-events

Startup times

Revision Plain With Sentry Diff
04e8394 1223.24 ms 1244.33 ms 21.08 ms
378d4bd 1216.53 ms 1241.19 ms 24.66 ms
8dae1f6 1212.60 ms 1226.52 ms 13.93 ms
8a562cc 1228.57 ms 1245.18 ms 16.60 ms

App size

Revision Plain With Sentry Diff
04e8394 22.31 KiB 771.93 KiB 749.62 KiB
378d4bd 22.31 KiB 784.05 KiB 761.73 KiB
8dae1f6 22.31 KiB 772.51 KiB 750.20 KiB
8a562cc 22.31 KiB 773.33 KiB 751.02 KiB

Previous results on branch: feat/deserializing-sentry-request

Startup times

Revision Plain With Sentry Diff
03a8d0a 1220.43 ms 1240.98 ms 20.54 ms

App size

Revision Plain With Sentry Diff
03a8d0a 22.31 KiB 798.50 KiB 776.18 KiB

@philipphofmann philipphofmann mentioned this pull request Feb 3, 2025
7 tasks
Copy link
Contributor

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.442%. Comparing base (6a01907) to head (9203218).
Report is 1 commits behind head on feat/deserializing-events.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feat/deserializing-events     #4784       +/-   ##
===============================================================
- Coverage                     91.496%   91.442%   -0.055%     
===============================================================
  Files                            640       642        +2     
  Lines                          75391     75593      +202     
  Branches                       27080     26550      -530     
===============================================================
+ Hits                           68980     69124      +144     
- Misses                          6315      6375       +60     
+ Partials                          96        94        -2     
Files with missing lines Coverage Δ
.../Swift/Protocol/Codable/SentryRequestCodable.swift 100.000% <100.000%> (ø)
...ests/SentryTests/Protocol/SentryRequestTests.swift 100.000% <100.000%> (ø)

... and 42 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a01907...9203218. Read the comment docs.

@philipphofmann philipphofmann merged commit 2114ce1 into feat/deserializing-events Feb 3, 2025
62 of 69 checks passed
@philipphofmann philipphofmann deleted the feat/deserializing-sentry-request branch February 3, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants