-
-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deserialize SentryRequest #4784
feat: Deserialize SentryRequest #4784
Conversation
Add Decodable/Deserializing of SentryRequest.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
04e8394 | 1223.24 ms | 1244.33 ms | 21.08 ms |
378d4bd | 1216.53 ms | 1241.19 ms | 24.66 ms |
8dae1f6 | 1212.60 ms | 1226.52 ms | 13.93 ms |
8a562cc | 1228.57 ms | 1245.18 ms | 16.60 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
04e8394 | 22.31 KiB | 771.93 KiB | 749.62 KiB |
378d4bd | 22.31 KiB | 784.05 KiB | 761.73 KiB |
8dae1f6 | 22.31 KiB | 772.51 KiB | 750.20 KiB |
8a562cc | 22.31 KiB | 773.33 KiB | 751.02 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/deserializing-events #4784 +/- ##
===============================================================
- Coverage 91.496% 91.442% -0.055%
===============================================================
Files 640 642 +2
Lines 75391 75593 +202
Branches 27080 26550 -530
===============================================================
+ Hits 68980 69124 +144
- Misses 6315 6375 +60
+ Partials 96 94 -2
... and 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
2114ce1
into
feat/deserializing-events
Add Decodable/Deserializing of SentryRequest.
#skip-changelog