Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deserializing SentryNSError #4743

Merged
merged 14 commits into from
Jan 23, 2025

Conversation

philipphofmann
Copy link
Member

This PR is based on #4724.

#skip-changelog

Copy link

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against fcdf983

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.202%. Comparing base (4df6ad9) to head (fcdf983).
Report is 1 commits behind head on feat/deserializing-events.

Additional details and impacted files

Impacted file tree graph

@@                       Coverage Diff                       @@
##           feat/deserializing-events     #4743       +/-   ##
===============================================================
- Coverage                     91.292%   91.202%   -0.090%     
===============================================================
  Files                            632       633        +1     
  Lines                          73221     73246       +25     
  Branches                       26682     26034      -648     
===============================================================
- Hits                           66845     66802       -43     
- Misses                          6279      6349       +70     
+ Partials                          97        95        -2     
Files with missing lines Coverage Δ
.../Swift/Protocol/Codable/SentryNSErrorCodable.swift 100.000% <100.000%> (ø)
...ests/SentryTests/Protocol/SentryNSErrorTests.swift 91.428% <100.000%> (+3.928%) ⬆️

... and 24 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df6ad9...fcdf983. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1211.41 ms 1228.65 ms 17.24 ms
Size 22.31 KiB 785.87 KiB 763.55 KiB

Baseline results on branch: feat/deserializing-events

Startup times

Revision Plain With Sentry Diff
04e8394 1223.24 ms 1244.33 ms 21.08 ms
8dae1f6 1212.60 ms 1226.52 ms 13.93 ms
8a562cc 1228.57 ms 1245.18 ms 16.60 ms

App size

Revision Plain With Sentry Diff
04e8394 22.31 KiB 771.93 KiB 749.62 KiB
8dae1f6 22.31 KiB 772.51 KiB 750.20 KiB
8a562cc 22.31 KiB 773.33 KiB 751.02 KiB

@philipphofmann philipphofmann mentioned this pull request Jan 23, 2025
7 tasks
@philipphofmann philipphofmann merged commit b6a8fd1 into feat/deserializing-events Jan 23, 2025
66 of 69 checks passed
@philipphofmann philipphofmann deleted the feat/deserializing-ns-error branch January 23, 2025 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants