Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Caching of sentry migrations should cover additional folders #3542

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

hubertdeng123
Copy link
Member

@hubertdeng123 hubertdeng123 commented Jan 16, 2025

We need to care about more than just src/sentry/migrations. We will need to account for files in src/sentry/**/migrations/*

Taken from https://github.com/getsentry/sentry/blob/afd74698180066223dee53991b7db26ca80ea3e5/.github/file-filters.yml#L90

@hubertdeng123 hubertdeng123 requested a review from BYK January 16, 2025 23:59
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.45%. Comparing base (52a1901) to head (31f2395).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3542   +/-   ##
=======================================
  Coverage   99.45%   99.45%           
=======================================
  Files           3        3           
  Lines         184      184           
=======================================
  Hits          183      183           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK enabled auto-merge (squash) January 17, 2025 07:15
@BYK BYK merged commit 7a89761 into master Jan 17, 2025
10 checks passed
@BYK BYK deleted the hubertdeng123/fix-caching-of-sentry-migrations branch January 17, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants