Introduce patches with external kafka #3521
Conversation
|
@BYK Do you want to take a look? |
There was a problem hiding this comment.
Good start but I'd extract the patch files from the shell script for readability and maintainability.
You may rename the top-level patches folder you created to optional-modifications and then have an actual patches folder under that which has the patch files namespaces by the script name like external-kafka/sentry.conf.py.patch etc.
patches/external-kafka.sh
Outdated
| EOF | ||
| ) | ||
| if [[ -f "docker-compose.override.yml" ]]; then | ||
| echo "🚨 docker-compose.override.yml already exists. You will need to modify it manually:" |
There was a problem hiding this comment.
Maybe try to be more helpful by sharing what needs to be changed in the file? Like "you need to remove the kafka service" or something among those lines.
There was a problem hiding this comment.
Although I print the docker-compose.override.yml content, yeah, this might be helpful too.
I don't want to have it as a patch file since I want the modified file to be specific. On this PR, I modify |
Warning
This is a work in progress. Haven't test it myself.
Blocked by Relay configuration.Talked to David Herberth, seems like we can't use environment variables for defining Kafka config for Relay at all.Continuation of getsentry/sentry-docs#11847
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.